Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer: make query nsqlookupd timeouts configurable #211

Closed
wants to merge 2 commits into from

Conversation

guyannanfei25
Copy link

when network is not well, 2 seconds may not be able dail success.
Use nsq.Config.DialTimeout to configure this parameter

@mreiferson
Copy link
Member

I think this is a good change, thanks for the contribution! However, I don't think we should lean on the existing DialTimeout.

Can we add new LookupdDialTimeout and LookupdRequestTimeout and thread those into the transport instantiation?

@mreiferson mreiferson changed the title make query nsqlookupd dail timeout configurable consumer: make query nsqlookupd dail timeout configurable Jun 8, 2017
@mreiferson mreiferson changed the title consumer: make query nsqlookupd dail timeout configurable consumer: make query nsqlookupd timeouts configurable Jun 8, 2017
@guyannanfei25
Copy link
Author

I think DialTimeout means parameter for all connections. Considering lookupds and nsqds are usually in same idc, the network condition is same. Besides even not in same idc, DialTimeout sets a little bigger do no harm for the ones in good network condition. Do we need new LookupdDialTimeout and LookupdRequestTimeout parameters ?

@mreiferson
Copy link
Member

My thinking is that if we're going to improve this, might as well do it completely and in an obvious way.

@jehiah
Copy link
Member

jehiah commented Jan 17, 2024

replaced by #360

@jehiah jehiah closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants